diff options
author | John Ankarström <john@ankarstrom.se> | 2022-07-19 12:16:15 +0200 |
---|---|---|
committer | John Ankarström <john@ankarstrom.se> | 2022-07-19 12:16:15 +0200 |
commit | 34c32802122ff80e79d850d44cbc84624d9a5840 (patch) | |
tree | b03f55581dda8ad8560ca8e0fd2f2eb341392345 /c/datalistview.cpp | |
parent | 2a7f4bcd4c04d0e48e580c4b11a94174bc5b09ae (diff) | |
download | EpisodeBrowser-34c32802122ff80e79d850d44cbc84624d9a5840.tar.gz |
Fix Prolog memory leaks.
Apparently foreign frames ARE needed when calling Prolog from C. The
official documentation is very terse and could make this clearer.
To summarize, whenever a term is created (e.g., PL_new_term_refs), its
reference count is increased by one. It is garbage-collected when its
reference count hits zero. But the reference count is never decreased
unless (a) control returns to Prolog after executing a foreign
predicate -- which does not happen in my application -- or (b) the
foreign frame in which the term was created is closed.
In other words, terms must be created within a foreign frame. This is
achieved by initializing a Frame object before creating the term and
destroying it once the term has served its purpose.
The destructor for Frame does not DISCARD the frame, only CLOSE it.
The former would also invalidate all data bound by the terms, which is
usually undesirable.
Diffstat (limited to 'c/datalistview.cpp')
-rw-r--r-- | c/datalistview.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/c/datalistview.cpp b/c/datalistview.cpp index c83c65f..704b689 100644 --- a/c/datalistview.cpp +++ b/c/datalistview.cpp @@ -39,6 +39,7 @@ void DataListView::ShowEpisode(const int iEpisode) lviKey.mask = LVIF_TEXT; lviValue.mask = LVIF_TEXT; + Frame f; const term_t t = PL_new_term_refs(3); if (!PL_put_integer(t,iEpisode)) return; const qid_t q = PL_open_query(NULL, PL_Q_NORMAL, |